Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename WithTags, clarify docs #2

Merged
merged 3 commits into from
Jun 29, 2018
Merged

Rename WithTags, clarify docs #2

merged 3 commits into from
Jun 29, 2018

Commits on Jun 29, 2018

  1. Rename WithTags to WithValues 

    This renames the WithTags method to WithValues, and removes the use of
the term "tag" from the documentation.  It's replaced with the phrase
"named values", and noted that "key" is used to refer to the name of a
particular value.
    @DirectXMan12
    DirectXMan12 committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    26dc218 View commit details
    Browse the repository at this point in the history

  2. Add note about restricted keys 

    This notes that certain keys (e.g. "error" or "msg") are often used by
implementations to attach other information, and thus should generally
not be used.
    @DirectXMan12
    DirectXMan12 committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    1b6b070 View commit details
    Browse the repository at this point in the history

  3. Forbid log levels less that zero 

    Some underlying implementations attach special meaning to negative log
levels (e.g. Zap, where those become positive log levels, which
eventually indicate special behavior), so we forbid them.
    @DirectXMan12
    DirectXMan12 committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    0c1bc35 View commit details
    Browse the repository at this point in the history