Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the outdated build constraint // +build #1035

Merged

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Jul 25, 2024

This PR removes outdated // +build comments. The "Build constraints" states:

Go versions 1.16 and earlier used a different syntax for build constraints, with a "// +build" prefix. The gofmt command will add an equivalent //go:build constraint when encountering the older syntax.

So, using only //go:build for Go 1.17+ is perfectly fine.

I used this command to remove lines starting with // +build:

find . -name '*.go' -exec sed -i '' '/^\/\/ +build/d' {} +

@alexandear alexandear force-pushed the chore/remove-outdated-build-constraint branch from e68dd26 to 15c2edd Compare July 25, 2024 16:55
@flimzy flimzy merged commit 6ae4cbb into go-kivik:master Jul 25, 2024
@alexandear alexandear deleted the chore/remove-outdated-build-constraint branch July 26, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants