Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming ID(), Key(), etc to RowID(), RowKey(), etc #98

Closed
flimzy opened this issue Apr 23, 2017 · 1 comment
Closed

Consider renaming ID(), Key(), etc to RowID(), RowKey(), etc #98

flimzy opened this issue Apr 23, 2017 · 1 comment
Labels
investigation
Milestone
1.0

Comments

@flimzy
Copy link
Member

flimzy commented Apr 23, 2017

No description provided.

@flimzy flimzy added this to the 1.0 milestone Apr 23, 2017
@flimzy
Copy link
Member Author

flimzy commented Apr 30, 2017

I think this is a bad idea. Most iterators expose these fields, and calling it RowID() for the BulkResults iterator doesn't sound consistent, and calling it BulkResultID seems unnecessarily long. So leaving it as-is.

@flimzy flimzy closed this as completed Apr 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
investigation
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@flimzy