Backward compatibility (username vs. login)

[martinhpedersen]

The rename from username to login broke compatibility with Drone and other API consumers.

This PR adds the old username field to User on json.Marshal, which resolves these compatibility issues while still maintaining Github-API compliance.

The patch has been tested against Drone 0.4.

[tboerger]

Something like this I have been talking about :)

[strk]

LGTM

[bkcsoft]

I'm not entirely sure how this would fix anything? 😕

[martinhpedersen]

Hi - so I guess some more explanation are in order :)

While cc453bf fixed the issue of incompatible push webhook payloads (gogs/gogs#3653), it also changed other parts of the API.

For instance, Drone 0.4 expects /api/v1/user/repos to return the username attribute (under owner) which has now been renamed to login.

This PR resolves these issues by marshalling the UserName field as both login and username in the JSON structure, thus ensuring backward compatibility with clients expecting the old username attribute.

Currently (without this patch) Drone 0.4 is unable to determine the owner of a repo, and in turn is unable to communicate with the gitea API.

See also @richmahn's comment in PR #9.

[bkcsoft]

@martinhpedersen Aaah! Now I get how it works 👍

LGTM

[martinhpedersen]

Excellent :) Thanks!