Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add explicit dimensions to navbar avatar #9986

Merged
merged 3 commits into from
Jan 26, 2020

Conversation

silverwind
Copy link
Member

this prevents a temporary layout change when navigating between pages with cache disabled.

this prevents a temporary layout change when navigating between
pages with cache disabled.
@codecov-io
Copy link

codecov-io commented Jan 25, 2020

Codecov Report

Merging #9986 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9986      +/-   ##
==========================================
- Coverage   42.26%   42.26%   -0.01%     
==========================================
  Files         610      610              
  Lines       80370    80372       +2     
==========================================
- Hits        33968    33966       -2     
- Misses      42223    42228       +5     
+ Partials     4179     4178       -1
Impacted Files Coverage Δ
models/list_options.go 57.89% <ø> (ø) ⬆️
routers/org/members.go 0% <0%> (ø) ⬆️
routers/repo/commit.go 29.66% <0%> (-0.26%) ⬇️
models/unit.go 37.03% <0%> (-2.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f4470b...e4a3406. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 25, 2020
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Jan 25, 2020
@lafriks lafriks added this to the 1.12.0 milestone Jan 25, 2020
@silverwind
Copy link
Member Author

silverwind commented Jan 26, 2020

Before:
before
After:
after

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 26, 2020
@silverwind
Copy link
Member Author

Also done the same on the frontpage. There is a lot more to be done on other pages, but I'll leave those for later.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 26, 2020
@lafriks lafriks merged commit c640a18 into go-gitea:master Jan 26, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants