Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crowdin update script #9969

Merged
merged 3 commits into from
Jan 25, 2020
Merged

Conversation

guillep2k
Copy link
Member

As title. Works fine in my environment.

@codecov-io
Copy link

codecov-io commented Jan 24, 2020

Codecov Report

Merging #9969 into master will increase coverage by 0.03%.
The diff coverage is 25.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9969      +/-   ##
==========================================
+ Coverage   42.23%   42.27%   +0.03%     
==========================================
  Files         610      610              
  Lines       80295    80364      +69     
==========================================
+ Hits        33915    33971      +56     
+ Misses      42217    42213       -4     
- Partials     4163     4180      +17
Impacted Files Coverage Δ
services/repository/repository.go 52.94% <0%> (-3.31%) ⬇️
modules/indexer/code/git.go 57.39% <13.04%> (ø) ⬆️
services/pull/pull.go 34.06% <24.07%> (-2.06%) ⬇️
modules/repofiles/update.go 39.52% <35.71%> (-0.84%) ⬇️
models/pull.go 42.91% <40%> (+0.92%) ⬆️
routers/repo/pull.go 29.06% <42.85%> (+0.39%) ⬆️
modules/process/manager.go 74.69% <0%> (-3.62%) ⬇️
services/pull/temp_repo.go 31.62% <0%> (-2.57%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
models/repo.go 49.96% <0%> (+0.13%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00d52aa...3c1df19. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 24, 2020
@guillep2k
Copy link
Member Author

Given that some translations are enclosed between quotes and some not, I've decided for a more strict pattern matching to avoid changing lines we're not supposed to. In the attachment you can see files before and after processing them with the script.

example.tar.gz

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 25, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 25, 2020
@techknowlogick techknowlogick merged commit a47cfdf into go-gitea:master Jan 25, 2020
@guillep2k guillep2k deleted the fix-crowdin-parse branch January 26, 2020 02:04
@jolheiser jolheiser mentioned this pull request Jan 30, 2020
3 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants