Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix activity count in TestRepoActivity #9959

Merged
merged 2 commits into from
Jan 24, 2020

Conversation

guillep2k
Copy link
Member

@guillep2k guillep2k commented Jan 24, 2020

Results from a git bisect concentrating on TestRepoActivity give me:

$ git bisect log
git bisect start
# bad: [99aad09bd041cb3e518f2ade4238beab84243366] Filter locales under 25% (#9893)
git bisect bad 99aad09bd041cb3e518f2ade4238beab84243366
# good: [9f40bb020eaea153eca77d3071a4f2cc8bcd2a8e] fix dump non-exist log directory (#9818)
git bisect good 9f40bb020eaea153eca77d3071a4f2cc8bcd2a8e
# bad: [948dec3d7519dd5b93db9a0027477da9f5331fb3] Allow hyphen in language name (#9873)
git bisect bad 948dec3d7519dd5b93db9a0027477da9f5331fb3
# bad: [fec1095f1729fefa8c0feca8cad8e8e81591d348] [Docs] add usefull info to REQUIRE_SIGNIN_VIEW (#9848)
git bisect bad fec1095f1729fefa8c0feca8cad8e8e81591d348
# bad: [737ea6d83cc62a84eefee48c169766009424ecec] Fix download file wrong content-type (#9825)
git bisect bad 737ea6d83cc62a84eefee48c169766009424ecec
# bad: [3c07d03c0388d3b86138572401281b51f2db9282] Add setting to set default and global disabled repository units. (#8788)
git bisect bad 3c07d03c0388d3b86138572401281b51f2db9282
# bad: [36943e56d66a2d711a6b0c27219ce91a3ddc020a] Add "Update Branch" button to Pull Requests (#9784)
git bisect bad 36943e56d66a2d711a6b0c27219ce91a3ddc020a
# first bad commit: [36943e56d66a2d711a6b0c27219ce91a3ddc020a] Add "Update Branch" button to Pull Requests (#9784)

I don't understand how the tests passed from then on, but this PR mostly passed with the usual glitch here and there (see https://drone.gitea.io/go-gitea/gitea/20124/3/6) passes successfully.

@guillep2k guillep2k changed the title WIP: Fix activity count Fix activity count in TestRepoActivity Jan 24, 2020
@guillep2k guillep2k marked this pull request as ready for review January 24, 2020 05:15
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@f6067a8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9959   +/-   ##
=========================================
  Coverage          ?   42.19%           
=========================================
  Files             ?      609           
  Lines             ?    79692           
  Branches          ?        0           
=========================================
  Hits              ?    33626           
  Misses            ?    41916           
  Partials          ?     4150

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6067a8...45a61ee. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 24, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 24, 2020
@zeripath
Copy link
Contributor

zeripath commented Jan 24, 2020

It's don't understand how 9873 could possibly break this test.


Nevermind it appears #9784 is the first bad commit.

But I still don't understand why that one should be bad either...

@zeripath zeripath added type/testing skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 24, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 24, 2020
@6543
Copy link
Member

6543 commented Jan 24, 2020

lets make the CI work again

@zeripath zeripath merged commit ad94a94 into go-gitea:master Jan 24, 2020
@guillep2k guillep2k deleted the fix-repo-act-test branch January 24, 2020 13:20
@6543 6543 mentioned this pull request Jan 24, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants