Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move fomantic target, update 'make help' #9945

Merged
merged 2 commits into from
Jan 23, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Jan 22, 2020

I'd like to run webpack without fomantic in the prereqs so move it to the generate target.

I can see why @lunny added it to js/css but I think it's better for now to separate those to be able to individually call those steps.

I'd like to run webpack without fomantic in the prereqs so move it to
the `generate` target.
@codecov-io
Copy link

codecov-io commented Jan 22, 2020

Codecov Report

Merging #9945 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9945      +/-   ##
==========================================
- Coverage   42.28%   42.27%   -0.02%     
==========================================
  Files         608      608              
  Lines       79393    79411      +18     
==========================================
- Hits        33574    33569       -5     
- Misses      41677    41701      +24     
+ Partials     4142     4141       -1
Impacted Files Coverage Δ
modules/setting/repository.go 51.42% <ø> (ø) ⬆️
routers/repo/repo.go 30.02% <0%> (-0.22%) ⬇️
modules/git/commit_archive.go 0% <0%> (ø) ⬆️
models/unit.go 37.03% <0%> (-2.47%) ⬇️
services/pull/check.go 54.54% <0%> (-2.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e994ac...e76206b. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 22, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 23, 2020
@techknowlogick techknowlogick added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Jan 23, 2020
@techknowlogick techknowlogick added this to the 1.12.0 milestone Jan 23, 2020
@techknowlogick
Copy link
Member

Could you also add reference to make fomantic to docs where make css/js is mention?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 23, 2020
@techknowlogick techknowlogick merged commit bfdfa9a into go-gitea:master Jan 23, 2020
@silverwind
Copy link
Member Author

silverwind commented Jan 23, 2020

I plan to merge the css and js targets into one webpack target soon (depends on #9944), I guess doc updates for fomantic can be included there.

@silverwind silverwind deleted the fomantic-make branch January 23, 2020 08:32
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants