Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make node_modules a order-only prerequisite #9923

Merged
merged 6 commits into from
Jan 25, 2020
Merged

make node_modules a order-only prerequisite #9923

merged 6 commits into from
Jan 25, 2020

Commits on Jan 21, 2020

  1. make node_modules a order-only prerequisite 

    Package installations and our fomantic step results in changes inside
node_modules which lead to make triggering that target unnecessarily.

Moved all node_modules prerequisites to order-only which will make skip
the timestamp check on in and eliminate useless npm calls.

Changes in package-lock.json will still result in reinstallation so
node_modules should stay consistent.
    @silverwind
    silverwind committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    bc6e7fc View commit details
    Browse the repository at this point in the history

  2. revert change to clean-all

    @silverwind
    silverwind committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    826b6f9 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2020

  1. Merge branch 'master' into make-node_modules

    @sapk
    sapk committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    60f6bb3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into make-node_modules

    @sapk
    sapk committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    6f64496 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2020

  1. Merge branch 'master' into make-node_modules

    @zeripath
    zeripath committed Jan 25, 2020
    Configuration menu
    Copy the full SHA
    921ba3f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into make-node_modules

    @zeripath
    zeripath committed Jan 25, 2020
    Configuration menu
    Copy the full SHA
    93666e1 View commit details
    Browse the repository at this point in the history