Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong font url on semantic-ui #9917

Merged
merged 2 commits into from
Jan 21, 2020
Merged

Fix wrong font url on semantic-ui #9917

merged 2 commits into from
Jan 21, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 21, 2020

As title. Caused by #9561

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 21, 2020
@lunny lunny added this to the 1.12.0 milestone Jan 21, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 21, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 21, 2020
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@0e8b27a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9917   +/-   ##
=========================================
  Coverage          ?   42.29%           
=========================================
  Files             ?      607           
  Lines             ?    79357           
  Branches          ?        0           
=========================================
  Hits              ?    33567           
  Misses            ?    41649           
  Partials          ?     4141

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e8b27a...f7b6f03. Read the comment docs.

@zeripath
Copy link
Contributor

Make lg-tm work

@zeripath zeripath merged commit ad3a957 into go-gitea:master Jan 21, 2020
@lunny lunny deleted the lunny/fix_wrong_font_url branch January 22, 2020 01:18
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lunny @codecov-io @zeripath @techknowlogick @GiteaBot @lafriks