Fix wrong permissions check when issues/prs shared operations #9885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9885 +/- ##
==========================================
+ Coverage 42.27% 42.39% +0.12%
==========================================
Files 605 605
Lines 79270 79304 +34
==========================================
+ Hits 33513 33624 +111
+ Misses 41625 41521 -104
- Partials 4132 4159 +27
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
Merged
guillep2k
approved these changes
Jan 20, 2020
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Jan 20, 2020
GiteaBot
added
lgtm/done
sapk
approved these changes
Jan 20, 2020
|
@lunny please send backport |
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Jan 20, 2020
…ea#9885) * Fix wrong permissions check when issues/prs shared operations * move redirect to the last of the function * fix swagger Co-authored-by: zeripath <[email protected]> Co-authored-by: Lauris BH <[email protected]>
lafriks
added a commit
that referenced
this pull request
Jan 20, 2020
…#9889) * Fix wrong permissions check when issues/prs shared operations * move redirect to the last of the function * fix swagger Co-authored-by: zeripath <[email protected]> Co-authored-by: Lauris BH <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also fixed a
typeparam on/issuesmissed on #9842Hint: If a page or an API is shared by issue and pullrequest, you must use
CanWriteIssuesOrPulls(issue.IsPull)but notCanWrite(models.UnitTypeIssues)to check the permisson.This PR will not be backport to v1.10.4 because it has been merged into #9884