Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix download file wrong content-type #9825

Merged
merged 3 commits into from
Jan 17, 2020
Merged

Fix download file wrong content-type #9825

merged 3 commits into from
Jan 17, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 17, 2020

Fix #9799

@lunny lunny added this to the 1.12.0 milestone Jan 17, 2020
sapk
sapk reviewed Jan 17, 2020
View reviewed changes
routers/repo/download.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 17, 2020
sapk
sapk approved these changes Jan 17, 2020
View reviewed changes
Copy link
Member

@sapk sapk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the error text to be more precise but still LGTM

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 17, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 17, 2020
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@7c0570d). Click here to learn what that means.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9825   +/-   ##
=========================================
  Coverage          ?   42.32%           
=========================================
  Files             ?      604           
  Lines             ?    79121           
  Branches          ?        0           
=========================================
  Hits              ?    33485           
  Misses            ?    41514           
  Partials          ?     4122
Impacted Files Coverage Δ
routers/repo/download.go 39.28% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c0570d...9494a37. Read the comment docs.

@lunny lunny merged commit 737ea6d into go-gitea:master Jan 17, 2020
@lunny lunny deleted the lunny/fix_down_charset branch January 17, 2020 12:16
lunny added a commit to lunny/gitea that referenced this pull request Jan 17, 2020
@lunny
Fix download file wrong content-type (go-gitea#9825)
cce88ca 
* Fix download file wrong content-type

* change the error text to be more precise

* fix test
@6543
Copy link
Member

6543 commented Jan 17, 2020

@lunny waiting for the backport ;)

lunny added a commit to lunny/gitea that referenced this pull request Jan 17, 2020
@lunny
Fix download file wrong content-type (go-gitea#9825)
db7f9e3 
* Fix download file wrong content-type

* change the error text to be more precise

* fix test
This was referenced Jan 17, 2020
Merged
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Jan 17, 2020
sapk pushed a commit that referenced this pull request Jan 17, 2020
@lunny @lafriks @sapk
Fix download file wrong content-type (#9825) (#9835)
b310686 
* Fix download file wrong content-type

* change the error text to be more precise

* fix test

Co-authored-by: Lauris BH <[email protected]>
sapk pushed a commit that referenced this pull request Jan 17, 2020
@lunny @lafriks @sapk
Fix download file wrong content-type (#9825) (#9834)
fe46185 
* Fix download file wrong content-type

* change the error text to be more precise

* fix test

Co-authored-by: Lauris BH <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sapk sapk sapk approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

File encoding wrong in raw page and bleam page.
5 participants
@lunny @codecov-io @6543 @sapk @GiteaBot