-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix download file wrong content-type #9825
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change the error text to be more precise but still LGTM
1b3a555
to
5c68f02
Compare
Codecov Report
@@ Coverage Diff @@
## master #9825 +/- ##
=========================================
Coverage ? 42.32%
=========================================
Files ? 604
Lines ? 79121
Branches ? 0
=========================================
Hits ? 33485
Misses ? 41514
Partials ? 4122
Continue to review full report at Codecov.
|
* Fix download file wrong content-type * change the error text to be more precise * fix test
@lunny waiting for the backport ;) |
* Fix download file wrong content-type * change the error text to be more precise * fix test
* Fix download file wrong content-type * change the error text to be more precise * fix test Co-authored-by: Lauris BH <[email protected]>
* Fix download file wrong content-type * change the error text to be more precise * fix test Co-authored-by: Lauris BH <[email protected]>
Fix #9799