Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve notification pager #9821

Merged
merged 3 commits into from
Jan 17, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 17, 2020

This PR has two improvements for notification pager.

  • When click read button on second/third page, it will stay the same page but not go to first page.
  • When click read button on last page and last record, it will go to the new last page but not go to first page.

@lunny lunny added the type/enhancement An improvement of existing functionality label Jan 17, 2020
@lunny lunny added this to the 1.12.0 milestone Jan 17, 2020
@codecov-io
Copy link

Codecov Report

Merging #9821 into master will decrease coverage by <.01%.
The diff coverage is 18.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9821      +/-   ##
==========================================
- Coverage   42.23%   42.22%   -0.01%     
==========================================
  Files         603      603              
  Lines       78880    78884       +4     
==========================================
- Hits        33313    33308       -5     
- Misses      41487    41494       +7     
- Partials     4080     4082       +2
Impacted Files Coverage Δ
routers/user/notification.go 39.81% <18.18%> (-1.54%) ⬇️
services/pull/patch.go 62.89% <0%> (-3.15%) ⬇️
services/pull/merge.go 50.69% <0%> (-0.7%) ⬇️
modules/log/file.go 77.62% <0%> (+2.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f40bb0...e77ffbf. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 17, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 17, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 17, 2020
@sapk
Copy link
Member

sapk commented Jan 17, 2020

Make LGTM work

@sapk sapk merged commit b641c68 into go-gitea:master Jan 17, 2020
@lunny lunny deleted the lunny/improve_notification_pager branch January 18, 2020 02:21
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants