Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Adapt Getting Source to use Go Modules #9743

Closed
wants to merge 2 commits into from
Closed

[Docs] Adapt Getting Source to use Go Modules #9743

wants to merge 2 commits into from

Conversation

bagasme
Copy link
Contributor

@bagasme bagasme commented Jan 13, 2020

Instead of hardcode clone path to $GOPATH/src, arbitrary path can now be use to clone Gitea.

I'm still unsure about different custom path flags, so I leave as is.

@bagasme bagasme mentioned this pull request Jan 13, 2020
Closed
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 13, 2020
@techknowlogick
Copy link
Member

We've had issues with swagger generation when not in GOPATH, and so I am hesitant to update these instructions, especially since they still work.

@6543
Copy link
Member

6543 commented Jan 13, 2020

I use make generate-swagger outside of GOPATH and it works ... but i can only speac for me ...

@bagasme bagasme mentioned this pull request Jan 14, 2020
Merged
@bagasme
Copy link
Contributor Author

bagasme commented Jan 14, 2020

Close via #9751

@bagasme bagasme closed this Jan 14, 2020
@bagasme bagasme deleted the docs/get-source-adapt-to-go-mod branch January 14, 2020 09:08
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bagasme @techknowlogick @6543 @GiteaBot