Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused lock #9709

Merged
merged 1 commit into from
Jan 11, 2020
Merged

Remove unused lock #9709

merged 1 commit into from
Jan 11, 2020

Conversation

zeripath
Copy link
Contributor

fix golangci-lints complaints...

@zeripath zeripath added this to the 1.12.0 milestone Jan 11, 2020
@6543 6543 mentioned this pull request Jan 11, 2020
Merged
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 11, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 11, 2020
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@edd3177). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9709   +/-   ##
=========================================
  Coverage          ?   42.18%           
=========================================
  Files             ?      592           
  Lines             ?    78155           
  Branches          ?        0           
=========================================
  Hits              ?    32967           
  Misses            ?    41143           
  Partials          ?     4045
Impacted Files Coverage Δ
modules/queue/queue_wrapped.go 8.94% <ø> (ø)
modules/queue/queue_disk_channel.go 73.22% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edd3177...5a6a5f5. Read the comment docs.

@zeripath zeripath merged commit 960ac36 into go-gitea:master Jan 11, 2020
@zeripath zeripath deleted the fix-golangci-lint branch January 11, 2020 19:06
@zeripath zeripath added the backport/done All backports for this PR have been created label Jan 12, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zeripath @codecov-io @6543 @jolheiser @GiteaBot