Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong original git service type on a migrated repository #9693

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 10, 2020

The original git service type should be 2 but now it's 0. This PR will fix that.

@lunny lunny added the type/bug label Jan 10, 2020
@lunny lunny added this to the 1.12.0 milestone Jan 10, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 10, 2020
@codecov-io
Copy link

Codecov Report

Merging #9693 into master will increase coverage by <.01%.
The diff coverage is 78.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9693      +/-   ##
==========================================
+ Coverage   42.25%   42.25%   +<.01%     
==========================================
  Files         589      590       +1     
  Lines       77989    78002      +13     
==========================================
+ Hits        32954    32960       +6     
- Misses      40994    41001       +7     
  Partials     4041     4041
Impacted Files Coverage Δ
models/migrations/migrations.go 1.3% <ø> (ø) ⬆️
models/migrations/v119.go 0% <0%> (ø)
modules/migrations/gitea.go 7.96% <0%> (-0.02%) ⬇️
routers/repo/repo.go 30.23% <100%> (+1.01%) ⬆️
models/repo.go 47.9% <100%> (+0.02%) ⬆️
models/task.go 24.65% <100%> (+0.51%) ⬆️
routers/api/v1/repo/repo.go 69.59% <100%> (+0.03%) ⬆️
services/pull/temp_repo.go 31.62% <0%> (-2.57%) ⬇️
services/pull/merge.go 53.14% <0%> (-0.79%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3143bb1...3a6fe74. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 10, 2020
@lunny lunny merged commit 7a3a90a into go-gitea:master Jan 10, 2020
@lunny lunny deleted the lunny/fix_gitservicetype branch January 10, 2020 15:35
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants