Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Add "before" query to ListIssueComments and ListRepoIssueComments #9685

Merged
merged 9 commits into from
Jan 13, 2020
Merged

[API] Add "before" query to ListIssueComments and ListRepoIssueComments #9685

merged 9 commits into from
Jan 13, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 9, 2020

as title

@codecov-io
Copy link

codecov-io commented Jan 10, 2020 •
edited
Loading

Codecov Report

Merging #9685 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9685      +/-   ##
==========================================
- Coverage   42.28%   42.28%   -0.01%     
==========================================
  Files         597      597              
  Lines       78276    78276              
==========================================
- Hits        33098    33097       -1     
- Misses      41128    41129       +1     
  Partials     4050     4050
Impacted Files Coverage Δ
modules/queue/workerpool.go 39.91% <0%> (-1.29%) ⬇️
models/gpg_key.go 55.03% <0%> (-0.56%) ⬇️
services/pull/merge.go 51.28% <0%> (+0.7%) ⬆️
services/pull/check.go 53.37% <0%> (+1.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8b5d62...ac3297f. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 10, 2020
@lunny lunny added modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality labels Jan 10, 2020
@6543 6543 changed the title [API] [code/refactor] add "before" query to ListIssueComments and ListRepoIssueComments [API] Add "before" query to ListIssueComments and ListRepoIssueComments Jan 10, 2020
@lunny
Copy link
Member

lunny commented Jan 11, 2020

It's betterto add some tests.

@techknowlogick techknowlogick added this to the 1.12.0 milestone Jan 11, 2020
gary-kim
gary-kim reviewed Jan 11, 2020
View reviewed changes
models/issue_comment.go Outdated Show resolved Hide resolved
6543
6543 commented Jan 11, 2020
View reviewed changes
models/issue_comment.go Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented Jan 11, 2020

@lunny done

@6543
Copy link
Member Author

6543 commented Jan 11, 2020

@gary-kim are you ok with this PR now ;)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 11, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 12, 2020
@sapk sapk merged commit 0b3aaa6 into go-gitea:master Jan 13, 2020
@6543 6543 deleted the api-refactor branch January 13, 2020 16:07
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@sapk sapk sapk approved these changes

@gary-kim gary-kim gary-kim approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@6543 @codecov-io @lunny @zeripath @sapk @gary-kim @techknowlogick @GiteaBot