-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix markdown anchor links #9673
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9673 +/- ##
=========================================
Coverage ? 42.28%
=========================================
Files ? 597
Lines ? 78279
Branches ? 0
=========================================
Hits ? 33099
Misses ? 41130
Partials ? 4050
Continue to review full report at Codecov.
|
@jolheiser What do you think of this. I remember us discussing doing this when we still had blackfriday. Was it much harder to do this fix on the blackfriday side? |
I don't remember exactly, but I think this would have broken other things in blackfriday that would have required more fixes, so we decided it wasn't worth it (at the time). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably shouldn't add user-content- to links that already have it. Although I dunno.
I'm also wondering about whether we'd ever want to let markdown rendered relative links link to non rendered content - is there a way of doing that? I guess those should be fully qualified as we can't tell when markdown is rendered.
Hmm I think I'll approve this. If we do merge it we should backport it to 1.11 |
Sorry I'm late, but how can we link to another comment in a thread with this change? 😕 |
You'd need to use the fully qualified link for it. (Which is what you should do anyway as you can't predict when the markdown is being rendered that you're on the comment page.) |
e.g. |
Hummm..... should we write a parser for our migration to |
This could be easily done with sql update with replace |
@mohe2015 can you send a backport ? |
Fix #9672
This fixes markdown anchor links by prepending
#user-content
to it.If this is not the fix you are looking or if you need tests feel free to create your own pull request.
Unfortunately I don't have the time to do that.