Fix markdown anchor links

[mohe2015]

Fix #9672

This fixes markdown anchor links by prepending #user-content to it.

If this is not the fix you are looking or if you need tests feel free to create your own pull request.
Unfortunately I don't have the time to do that.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@b11a3cb). Click here to learn what that means.
The diff coverage is 40.24%.

@@            Coverage Diff            @@
##             master    #9673   +/-   ##
=========================================
  Coverage          ?   42.28%           
=========================================
  Files             ?      597           
  Lines             ?    78279           
  Branches          ?        0           
=========================================
  Hits              ?    33099           
  Misses            ?    41130           
  Partials          ?     4050

Impacted Files	Coverage Δ
modules/auth/repo_form.go	43.47% <ø> (ø)
models/issue_tracked_time.go	58.67% <ø> (ø)
modules/setting/git.go	65.38% <ø> (ø)
modules/queue/queue_disk_channel.go	73.22% <ø> (ø)
models/migrations/migrations.go	1.3% <ø> (ø)
modules/queue/queue_wrapped.go	8.94% <ø> (ø)
modules/repository/repo.go	26.28% <0%> (ø)
services/pull/pull.go	21.67% <0%> (ø)
cmd/doctor.go	0% <0%> (ø)
models/migrations/v119.go	0% <0%> (ø)
... and 62 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b11a3cb...fee608d. Read the comment docs.

[zeripath]

@jolheiser What do you think of this. I remember us discussing doing this when we still had blackfriday. Was it much harder to do this fix on the blackfriday side?

[jolheiser]

@jolheiser What do you think of this. I remember us discussing doing this when we still had blackfriday. Was it much harder to do this fix on the blackfriday side?

I don't remember exactly, but I think this would have broken other things in blackfriday that would have required more fixes, so we decided it wasn't worth it (at the time).

[zeripath]

We probably shouldn't add user-content- to links that already have it. Although I dunno.

I'm also wondering about whether we'd ever want to let markdown rendered relative links link to non rendered content - is there a way of doing that? I guess those should be fully qualified as we can't tell when markdown is rendered.

[zeripath]

Hmm I think I'll approve this.

If we do merge it we should backport it to 1.11

[guillep2k]

Sorry I'm late, but how can we link to another comment in a thread with this change? 😕

[zeripath]

You'd need to use the fully qualified link for it. (Which is what you should do anyway as you can't predict when the markdown is being rendered that you're on the comment page.)

[zeripath]

e.g. https://github.com/go-gitea/gitea/pull/9673#issuecomment-575176485

or /go-gitea/gitea/pull/9673#issuecomment-575176485

[guillep2k]

You'd need to use the fully qualified link for it. (Which is what you should do anyway as you can't predict when the markdown is being rendered that you're on the comment page.)

Hummm..... should we write a parser for our migration to gitea.com, replacing https://github.com/go-gitea/gitea/ with https://gitea.com/gitea/gitea/?

[lafriks]

This could be easily done with sql update with replace

[sapk]

@mohe2015 can you send a backport ?