fix #9648 | use filepath.IsAbs instead of path.IsAbs #9651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapk
approved these changes
Jan 8, 2020
GiteaBot
added
the
lgtm/need 1
|
need backport lable to 1.11.0 🗡️ |
zeripath
approved these changes
Jan 8, 2020
GiteaBot
added
lgtm/done
|
I've killed a few builds to try to get this merged quicker. @jolheiser are you able to test that this fixes this on windows? |
|
@zeripath you killed the backport also 😄 Even if it doesn't fix the related issue, filepath has windows support compared to path. |
|
The issue with filepath is that it always changes / to \ which may or may not be correct. I would have used it originally but I wasn't sure if leveldb tolerated it. I assumed that IsAbs would work. It's annoying to be stuck in this half world. You never know when you have to use filepath or path. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: golang/go#1483
PS: this need a better title ... maby?