Improve PR info in default merge message

[shashvat-kedia]

Fix for issue #9552.

[6543]

@SD1998 think you took the wrong issue number

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@c88f0fe). Click here to learn what that means.
The diff coverage is 20%.

@@            Coverage Diff            @@
##             master    #9635   +/-   ##
=========================================
  Coverage          ?   42.22%           
=========================================
  Files             ?      582           
  Lines             ?    77109           
  Branches          ?        0           
=========================================
  Hits              ?    32559           
  Misses            ?    40552           
  Partials          ?     3998

Impacted Files	Coverage Δ
models/pull.go	46.25% <20%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c88f0fe...0cd12d1. Read the comment docs.

[6543]

Suggested change

	return fmt.Sprintf("Merge pull request %d: '%s' from '%s' of %s/%s into %s", pr.IssueID, pr.Issue.Title, pr.HeadBranch, pr.MustHeadUserName(), pr.HeadRepo.Name, pr.BaseBranch)
	return fmt.Sprintf("Merge pull request '%s' (#%d) from %s/%s into %s", pr.Issue.Title, pr.Issue.Index, pr.MustHeadUserName(), pr.HeadBranch, pr.BaseBranch)

this is more like github + has still the PR title in it

[zeripath]

You need index not ID

[6543]

more 👀 see more - added to suggestion

[shashvat-kedia]

@6543 I have made the change.

[bagasme]

OK, but can it be merged for v1.12?

[lunny]

@bagasme yes, it will.

[zeripath]

Make lg-tm work

[danwilliams]

@SD1998 @zeripath this PR does not fully satisfy ticket #9552, as it only changes the merge title, and does not put the PR description into the merge commit message body. Hence part of the issue remains outstanding.

However, my question is how to modify this without altering the source code and recompiling? I preferred the old format, before this change. Many people will prefer the new format. It seems to be possible to put templates into each repository, to override - but is there a way to apply a system-wide default? If so, this would allow the both my question and the remaining parts of the issue to be addressed.

Apologies if this is covered somewhere in documentation, but I could not find anything.