chore(PR): Add Reviewed-on in commit message

[appleboy]

Add Reviewed-on in the commit message.

Screenshot:

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@ccf9988). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #9623   +/-   ##
=========================================
  Coverage          ?   42.18%           
=========================================
  Files             ?      583           
  Lines             ?    77253           
  Branches          ?        0           
=========================================
  Hits              ?    32589           
  Misses            ?    40656           
  Partials          ?     4008

Impacted Files	Coverage Δ
modules/webhook/telegram.go	3.97% <0%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccf9988...d1a66ca. Read the comment docs.

[6543]

Dont know if this is usefull - the pr number is already in the commit title

[sapk]

@6543 it is from linux kernel convention. https://git.wiki.kernel.org/index.php/CommitMessageConventions

[zeripath]

I think I'd prefer Referenced-PR: or something like that.

The trouble with Reviewed-On: is that it makes me think of a date, a particular commit or computer architecture not the PR number and so the PR number comes as a bit of a shock.

[appleboy]

I take golang/go@edf3ec9 as reference

[zeripath]

Ah I had no idea they were using that. Have you been able to find a document that has all their tags?

OK, I wonder if we should be putting the full url in there then or at least the reponame/username.

---

which is what you're doing...

[zeripath]

Now sticking the full URL in could unintentionally expose private giteas.

I guess this needs probably needs a config value. (yet another)

I would guess options include: full URL, owner/reponame#1, owner/reponame!1, #1, !1, none?

[lunny]

@zeripath If you can visit the codes or the pull, then you have know the private repository URL before the commit message tell you. I don't think it's a problem.

If we put owner/reponame#1, it will only be a link on gitea but not git commands or other git tools.

[guillep2k]

@zeripath If you can visit the codes or the pull, then you have know the private repository URL before the commit message tell you. I don't think it's a problem.

Unless it's a public mirror of a private repo from another instance.

A full URL would not survive well a site migration, but a relative one will only work locally which is a boomer as well.

[sapk]

It could be configurable on repository level (furthermore maybe add a commit template ?) but in the meantime the user can simply remove the text ?

[appleboy]

@sapk Yes. Users can simply remove the text before merging the PR.

[zeripath]

Make lg-tm work

[danwilliams]

@appleboy @sapk @zeripath is there an issue that covers making this configurable as a system-wide default? I'd like to keep my eye on it if so, as it is tedious to manually remove the text for every merge.

(I could not find one in a few minutes of searching.)

[sapk]

I don't think so but it could maybe be attached to #9823 to provide commit template for commit (update and merge) globally, by org/user or repo.