-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow repo admin to merge PR regardless of review status #9611
Allow repo admin to merge PR regardless of review status #9611
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9611 +/- ##
==========================================
+ Coverage 42.21% 42.21% +<.01%
==========================================
Files 590 591 +1
Lines 78085 78085
==========================================
+ Hits 32961 32964 +3
+ Misses 41077 41075 -2
+ Partials 4047 4046 -1
Continue to review full report at Codecov.
|
@zeripath that is not correct English |
I reformulated the messages instead 😏 |
@@ -53,11 +54,6 @@ func Merge(pr *models.PullRequest, doer *models.User, baseGitRepo *git.Repositor | |||
} | |||
prConfig := prUnit.PullRequestsConfig() | |||
|
|||
if err := pr.CheckUserAllowedToMerge(doer); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So all permissions check are out of this function?
Screenshot