Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Fix bug when migrate from API (#8631) #9563

Merged
merged 4 commits into from
Jan 1, 2020
Merged

[Backport] Fix bug when migrate from API (#8631) #9563

merged 4 commits into from
Jan 1, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Dec 31, 2019

backport #8631

@lunny @6543
Fix bug when migrate from API (go-gitea#8631)
f818f9c 
* fix bug when migrate from API

* fix test

* fix test

* improve

* fix error message
@techknowlogick techknowlogick added this to the 1.10.2 milestone Dec 31, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 31, 2019
6543
6543 commented Dec 31, 2019
View reviewed changes
routers/api/v1/repo/repo.go Outdated Show resolved Hide resolved
@lunny
Copy link
Member

lunny commented Dec 31, 2019

Maybe another of my PRs on v1.10.2 fixed this? #9511

@6543
Copy link
Member Author

6543 commented Dec 31, 2019

@lunny I just created a backport ... should I close it

zeripath
zeripath reviewed Dec 31, 2019
View reviewed changes
models/repo.go Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented Jan 1, 2020

@zeripath done

@6543
Copy link
Member Author

6543 commented Jan 1, 2020

@lunny can this go in?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 1, 2020
@lafriks lafriks merged commit cb3fe4c into go-gitea:release/v1.10 Jan 1, 2020
@6543 6543 deleted the backport-8631 branch January 1, 2020 23:40
@6543 6543 mentioned this pull request Jan 2, 2020
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath left review comments

@techknowlogick techknowlogick techknowlogick approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.10.2
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@6543 @lunny @techknowlogick @lafriks @zeripath @GiteaBot