Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use npm to manage fomantic and only build needed components #9561
Use npm to manage fomantic and only build needed components #9561
Changes from 1 commit
ca23114
d195d0d
a56ee78
0ee3b2b
eb3c9ea
123ee04
07d0b71
1764412
627bd16
02d0f79
b3013b1
4f30548
7818e13
b11bdba
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it is possible to have this as a non-phony target that depends on
package-lock.json
, so it would only run if dependencies change.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I'd suggest the target to be adjusted to provide one or more output files, like
public/fomantic/semantic.min.js
andpublic/fomantic/semantic.min.css
. We can still have a phonyfomantic
target that depends on that file to trigger it on-demand.