Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] add comments endpoint for single comment #9494

Merged
merged 2 commits into from
Jan 8, 2020
Merged

[API] add comments endpoint for single comment #9494

merged 2 commits into from
Jan 8, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Dec 25, 2019 •
edited
Loading

close #9486
usefull at #4811 (#9488)

add GET /repos/{owner}/{repo}/issues/comments/{id}

GitHub reference spec: link

@6543 6543 mentioned this pull request Dec 25, 2019
Merged
12 tasks
@codecov-io
Copy link

codecov-io commented Dec 25, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@5749b26). Click here to learn what that means.
The diff coverage is 72.46%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #9494   +/-   ##
========================================
  Coverage          ?   42.2%           
========================================
  Files             ?     578           
  Lines             ?   76138           
  Branches          ?       0           
========================================
  Hits              ?   32135           
  Misses            ?   40019           
  Partials          ?    3984
Impacted Files Coverage Δ
routers/api/v1/api.go 73.96% <100%> (ø)
routers/api/v1/repo/issue_comment.go 56.22% <70.76%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5749b26...ed287f6. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 25, 2019
zeripath
zeripath reviewed Dec 25, 2019
View reviewed changes
models/issue_comment.go Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented Dec 25, 2019

@zeripath I thought comment.APIURL() is a genaral function wich #9488 will use - but i dont know when this get ready ... so I thought add this smal func to this one ... but yes its unrelated - removed

@6543 6543 requested a review from zeripath December 25, 2019 18:07
@lunny lunny added the modifies/api This PR adds API routes or modifies them label Dec 26, 2019
@lunny lunny added this to the 1.12.0 milestone Dec 26, 2019
@6543 6543 force-pushed the api-comments-get-single branch 2 times, most recently from 05cb801 to ee6da6e Compare January 7, 2020 01:26
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 7, 2020
@6543 6543 mentioned this pull request Jan 7, 2020
Open
7 tasks
@6543
add GET /repos/{owner}/{repo}/issues/comments/{id}
17d742a 
 and complete error list for swagger in other func
@6543
add repo check
901cca5
@6543
Copy link
Member Author

6543 commented Jan 8, 2020

@techknowlogick @guillep2k done

@GiteaBot GiteaBot removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 8, 2020
@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Jan 8, 2020
@6543
Copy link
Member Author

6543 commented Jan 8, 2020

ready for merge 🚀

@lunny lunny merged commit e88d67b into go-gitea:master Jan 8, 2020
@6543 6543 deleted the api-comments-get-single branch January 8, 2020 08:41
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny left review comments

@guillep2k guillep2k guillep2k left review comments

@techknowlogick techknowlogick techknowlogick approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

[API] add endpoint for single comment
7 participants
@6543 @codecov-io @lunny @techknowlogick @zeripath @guillep2k @GiteaBot