Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate reviews when migrating repository from github #9463

Merged
merged 17 commits into from
Jan 23, 2020
Merged

Migrate reviews when migrating repository from github #9463

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ce2c4ed
fix typo
lunny Dec 22, 2019
8ae3e2d
fix lint
lunny Dec 22, 2019
2263c5a
Migrate reviews when migrating repository from github
lunny Dec 22, 2019
abe4e22
Added test and migration when external user login
lunny Jan 4, 2020
d200081
fix test
lunny Jan 4, 2020
beea95e
fix commented state
lunny Jan 4, 2020
9824001
Some improvements
lunny Jan 4, 2020
e7ff3be
fix bug when get pull request and ref original author on code comments
lunny Jan 5, 2020
6a1e7d4
Fix migrated line; Added comment for review
lunny Jan 10, 2020
8a9c2d2
Don't load all pull requests attributes
lunny Jan 10, 2020
1ec2c77
Fix typo
lunny Jan 10, 2020
16f183e
wrong change copy head
lunny Jan 10, 2020
579ef41
fix tests
lunny Jan 10, 2020
3461e21
fix reactions
lunny Jan 16, 2020
948b8a6
Fix test
lunny Jan 17, 2020
89af332
fix fmt
lunny Jan 19, 2020
f37545b
fix review comment reactions
lunny Jan 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
fix review comment reactions
  • Loading branch information
@lunny
lunny committed Jan 23, 2020
commit f37545bca0ad2cc83adf119a020ba75cd3db7516
2 changes: 0 additions & 2 deletions modules/migrations/gitea.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,8 +821,6 @@ func (g *GiteaLocalUploader) CreateReviews(reviews ...*base.Review) error {
}

cms = append(cms, &cm)

// TODO: Reactions
}

return models.InsertReviews(cms)
Expand Down
2 changes: 1 addition & 1 deletion modules/migrations/github.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,7 @@ func (g *GithubDownloaderV3) convertGithubReviewComments(cs []*github.PullReques
var reactions []*base.Reaction
for i := 1; ; i++ {
g.sleep()
res, resp, err := g.client.Reactions.ListIssueCommentReactions(g.ctx, g.repoOwner, g.repoName, c.GetID(), &github.ListOptions{
res, resp, err := g.client.Reactions.ListPullRequestCommentReactions(g.ctx, g.repoOwner, g.repoName, c.GetID(), &github.ListOptions{
Page: i,
PerPage: 100,
})
Expand Down