Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vendor Update] go-swagger v0.20.1 -> v0.21.0 #9410

Merged
merged 2 commits into from
Dec 18, 2019

Conversation

6543
Copy link
Member

@6543 6543 commented Dec 18, 2019

No description provided.

@6543 6543 changed the title Vendor Update go-swagger v0.20.1 -> v0.21.0 [Vendor Update] go-swagger v0.20.1 -> v0.21.0 Dec 18, 2019
Copy link
Member

@sapk sapk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lot of //indirect added to go.mod that could maybe cleaned by go mod tidy but still LGTM

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 18, 2019
@6543
Copy link
Member Author

6543 commented Dec 18, 2019

@sapk good to know

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 18, 2019
@codecov-io
Copy link

Codecov Report

Merging #9410 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9410      +/-   ##
==========================================
- Coverage   41.49%   41.49%   -0.01%     
==========================================
  Files         569      569              
  Lines       74322    74322              
==========================================
- Hits        30843    30839       -4     
- Misses      39639    39641       +2     
- Partials     3840     3842       +2
Impacted Files Coverage Δ
models/unit.go 62.16% <0%> (-5.41%) ⬇️
services/pull/temp_repo.go 31.62% <0%> (-2.57%) ⬇️
modules/repository/repo.go 33.55% <0%> (-1.98%) ⬇️
modules/migrations/migrate.go 24.21% <0%> (-1.58%) ⬇️
models/webhook.go 69.39% <0%> (-1.07%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
modules/migrations/gitea.go 9.03% <0%> (-0.64%) ⬇️
models/repo.go 48.2% <0%> (+0.1%) ⬆️
models/error.go 33.2% <0%> (+1.11%) ⬆️
modules/task/migrate.go 28.94% <0%> (+3.94%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d811bc...dea929e. Read the comment docs.

@6543
Copy link
Member Author

6543 commented Dec 18, 2019

@sapk ready to 🚀

@sapk sapk merged commit 90057ca into go-gitea:master Dec 18, 2019
@6543 6543 deleted the update-swagger branch December 18, 2019 15:07
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants