Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move push commits from models to modules/repository #9370

Merged
merged 9 commits into from
Jan 10, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 16, 2019

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Dec 16, 2019
@lunny lunny force-pushed the lunny/push_commits branch 2 times, most recently from 1a4bad3 to 1d40881 Compare December 17, 2019 12:10
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 17, 2019
@lunny lunny force-pushed the lunny/push_commits branch 2 times, most recently from 59525f8 to 3e9934b Compare December 19, 2019 00:50
@codecov-io
Copy link

codecov-io commented Dec 19, 2019

Codecov Report

Merging #9370 into master will increase coverage by 0.02%.
The diff coverage is 55.61%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #9370      +/-   ##
=========================================
+ Coverage   42.17%   42.2%   +0.02%     
=========================================
  Files         583     584       +1     
  Lines       77160   77158       -2     
=========================================
+ Hits        32541   32561      +20     
+ Misses      40616   40591      -25     
- Partials     4003    4006       +3
Impacted Files Coverage Δ
models/action.go 46.87% <ø> (-11.09%) ⬇️
modules/repository/repo.go 26.28% <0%> (-7.27%) ⬇️
services/mirror/mirror.go 19.4% <0%> (+0.65%) ⬆️
modules/templates/helper.go 40.24% <0%> (ø) ⬆️
modules/notification/action/action.go 35.65% <0%> (ø) ⬆️
models/update.go 6.38% <0%> (-6.32%) ⬇️
modules/repofiles/action.go 63.63% <100%> (ø) ⬆️
modules/notification/indexer/indexer.go 50.72% <100%> (ø) ⬆️
services/release/release.go 27.04% <100%> (ø) ⬆️
modules/notification/webhook/webhook.go 37.97% <50%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9309e5...9d6b264. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 7, 2020
@lunny lunny added this to the 1.12.0 milestone Jan 8, 2020
@lunny
Copy link
Member Author

lunny commented Jan 10, 2020

make L-G-T-M work

@lunny lunny merged commit 99d869f into go-gitea:master Jan 10, 2020
@lunny lunny deleted the lunny/push_commits branch January 10, 2020 09:34
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants