fix: wrong pages number which includes private repository count. #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
trusted LGTM |
tboerger
added
the
lgtm/need 1
ethantkoenig
suggested changes
Feb 6, 2017
models/repo.go
Outdated
| return getPublicRepositoryCount(x, u) | ||
| } | ||
|
|
||
| // GetPrivateRepositoryCount returns the total number of public repositories of user. |
There was a problem hiding this comment.
Why? Already has getPrivateRepositoryCount private function.
There was a problem hiding this comment.
returns the total number of public repositories of user. -> returns the total number of private repositories of user. 😄
There was a problem hiding this comment.
@ethantkoenig understood. 👍
models/repo_test.go
Outdated
| func TestGetRepositoryCount(t *testing.T) { | ||
| assert.NoError(t, PrepareTestDatabase()) | ||
|
|
||
| count, _ := GetRepositoryCount(&User{ID: int64(10)}) |
There was a problem hiding this comment.
Could we assert that the returned error is nil, instead of just ignoring it?
models/repo_test.go
Outdated
| func TestGetPublicRepositoryCount(t *testing.T) { | ||
| assert.NoError(t, PrepareTestDatabase()) | ||
|
|
||
| count, _ := GetPublicRepositoryCount(&User{ID: int64(10)}) |
models/repo_test.go
Outdated
| func TestGetPrivateRepositoryCount(t *testing.T) { | ||
| assert.NoError(t, PrepareTestDatabase()) | ||
|
|
||
| count, _ := GetPrivateRepositoryCount(&User{ID: int64(10)}) |
routers/user/profile.go
Outdated
| if showPrivate { | ||
| total = ctxUser.NumRepos | ||
| } else { | ||
| count, _ := models.GetPublicRepositoryCount(ctxUser) |
There was a problem hiding this comment.
Could we check if the returned error is nil instead of ignoring it?
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #843
GetPublicRepositoryCountfuncGetPrivateRepositoryCountfunc