Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom public files #782

Merged
merged 2 commits into from
Jan 28, 2017
Merged

Allow custom public files #782

merged 2 commits into from
Jan 28, 2017

Conversation

tboerger
Copy link
Member

@tboerger tboerger commented Jan 28, 2017

This allows serving custom public files again, just place files into custom/public/ and they will be available to the builtin server.

Fixes #758

@tboerger tboerger added the type/enhancement An improvement of existing functionality label Jan 28, 2017
@tboerger tboerger added this to the 1.1.0 milestone Jan 28, 2017
@andreynering
Copy link
Contributor

I just tried it, and you cannot override Gitea content, just serve aditional content. Is this the expected behavior?

Otherwise LGTM

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 28, 2017
@tboerger
Copy link
Member Author

I have not tried to override a file. Need to check if I can do this by updating the ordering

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 28, 2017
@tboerger
Copy link
Member Author

So I can confirm that changing the call order works. With this PR I'm able to override also existing files like the logo:

bildschirmfoto 2017-01-28 um 18 45 02

@Bwko
Copy link
Member

Bwko commented Jan 28, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 28, 2017
@tboerger tboerger merged commit 78535fb into go-gitea:master Jan 28, 2017
@tboerger tboerger deleted the custom-fixes branch January 30, 2017 08:30
@kristofer
Copy link

in spite of all this, favicon.ico doesn't work?

@lunny
Copy link
Member

lunny commented Apr 24, 2018

put your favicon in custom/public/img/favicon.png

@kristofer
Copy link

ah, yes. thank you.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 13, 2020
@tboerger
Copy link
Member Author

Teabot getting crazy?

@Spriithy
Copy link

Hahaha, no ! I had an issue related to this (favicon wouldn't override) even when refreshing without cache and other media overrides worked (gitea-sm.png for instance). But rebooting my PC (not the server) seemed to fix this problem so I deleted my comment...

Sorry for the inconvenience !

@tboerger
Copy link
Member Author

Which still doesn't explain the label change from the bot

@jolheiser
Copy link
Member

It's probably confused since the PR has no reviews, yet had an lgtm/done label?
Not sure how it calculates using LGTM comments, though, as there are technically two of those.

@GiteaBot GiteaBot removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 13, 2020
@Spriithy
Copy link

I didn't add one in my original comment for sure

@tboerger
Copy link
Member Author

It already had the labels previously...

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to override default logo
8 participants