Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add search repository on dashboard. #773

Merged
merged 1 commit into from
Jan 30, 2017
Merged

Conversation

appleboy
Copy link
Member

screen shots:

screen shot 2017-01-27 at 11 25 09 pm

@lunny
Copy link
Member

lunny commented Jan 27, 2017

How about put it in the topbar near the logo, just like github?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 27, 2017
@lunny lunny added this to the 1.1.0 milestone Jan 27, 2017
@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jan 27, 2017
@appleboy
Copy link
Member Author

appleboy commented Jan 27, 2017

This search bar just like GitHub dashboard.

screen shot 2017-01-27 at 11 52 06 pm

Login your account and try it out on https://github.com

@appleboy
Copy link
Member Author

Related Gogs Issue comment. gogs/gogs#4028 (comment)

@andreynering
Copy link
Contributor

LGTM

There's a thing that we may consider in the future.

Gitea will show only 15 repos in this box. GitHub do search for all repos, while this patch will search only for those 15 being showed.

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 28, 2017
@appleboy
Copy link
Member Author

screen shot 2017-01-30 at 1 17 48 pm

@andreynering Github only shows 20 items and click bottom button to show all repositories.

@appleboy
Copy link
Member Author

Maybe we can change Gitea behavior to load user all reposotories.

@lunny
Copy link
Member

lunny commented Jan 30, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 30, 2017
@lunny lunny merged commit d078aa3 into go-gitea:master Jan 30, 2017
@appleboy appleboy deleted the search-2 branch January 30, 2017 08:32
@gsantner
Copy link

gsantner commented Feb 1, 2017

@appleboy My 2c:
Nice, thank you for implementing. I would suggest to include some repositories favorited/stared by user.

And also to push up repos in the repo list, if their wiki gets updated by the user. Currently repos only get to top if there were commits to the repo. -> Makes it also appear as search result

@bkcsoft
Copy link
Member

bkcsoft commented Feb 2, 2017

Maybe we can change Gitea behavior to load user all reposotories.

Please no. We should have a separate search-function that still limits (paginates) to the set limit :)

@appleboy
Copy link
Member Author

appleboy commented Feb 2, 2017

@gsantner The search bar feature has been implemented by #787

@gsantner
Copy link

gsantner commented Feb 2, 2017

@appleboy Oh, yeah, but not merged to develop, so didn't test. Would the wiki part be much work?

@appleboy
Copy link
Member Author

appleboy commented Feb 2, 2017

@gsantner No. not include wiki module.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants