Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract the username and password from the mirror url #7651

Merged
merged 15 commits into from
Aug 16, 2019
Merged

Extract the username and password from the mirror url #7651

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
607971b
Explode out mirror username and password
zeripath Jul 28, 2019
9705ff3
Update models/repo_mirror.go
zeripath Jul 28, 2019
216d58d
Just roundtrip the password
zeripath Jul 29, 2019
a4b021f
remove unused declaration
zeripath Jul 29, 2019
b1473eb
Update templates/repo/settings/options.tmpl
zeripath Aug 6, 2019
1706c88
Merge branch 'master' into hide-passwords-in-urls
lafriks Aug 10, 2019
20cc428
Merge branch 'master' into hide-passwords-in-urls
lunny Aug 11, 2019
f7a6166
Merge branch 'master' into hide-passwords-in-urls
lunny Aug 14, 2019
c969a0b
Merge branch 'master' into hide-passwords-in-urls
lunny Aug 14, 2019
a1ccd3e
Merge branch 'master' into hide-passwords-in-urls
lunny Aug 14, 2019
fbe1381
Merge branch 'master' into hide-passwords-in-urls
lunny Aug 14, 2019
7261119
Merge branch 'master' into hide-passwords-in-urls
lafriks Aug 15, 2019
db3ee4a
Merge branch 'master' into hide-passwords-in-urls
lunny Aug 15, 2019
7360686
Merge branch 'master' into hide-passwords-in-urls
lunny Aug 15, 2019
2fef0ba
Merge branch 'master' into hide-passwords-in-urls
zeripath Aug 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update templates/repo/settings/options.tmpl
  • Loading branch information
@zeripath
zeripath committed Aug 6, 2019
commit b1473ebdd4486923d4610e47029af1a58f888ce2
2 changes: 1 addition & 1 deletion templates/repo/settings/options.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
<div class="ui accordion optional field">
<label class="ui title {{if .Err_Auth}}text red active{{end}}">
<i class="icon dropdown"></i>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would remove that <i> as the section is not expandable

Copy link
Member

@silverwind silverwind Aug 5, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or actually find out why semantic-ui does not make it toggleable, something in the HTML I assume.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the issue is that the HTML is unbalanced. The <label for=""> tag below should probably be closed on the same line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya! I have no idea how that unbalanced label sneaked in.

So the idea of sticking a label in there was to keep the formatting of collapsable section title the same - it looked weird to my eyes when it was different to all the other bits. I'll have to see if closing that label has changed that back.

<label for="">{{.i18n.Tr "repo.need_auth"}}
<label for="">{{.i18n.Tr "repo.need_auth"}}</label>
</label>
<div class="content {{if .Err_Auth}}active{{else if .Mirror.Username}}active{{end}}">
<div class="inline field {{if .Err_Auth}}error{{end}}">
Expand Down