Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Implement Elastic Search Code Indexer #7592

Closed
wants to merge 11 commits into from
Closed

[WIP] Implement Elastic Search Code Indexer #7592

wants to merge 11 commits into from

Conversation

jeffliu27
Copy link

Creates Issue indexer as a separate package: "codes" (will be changed to code later).
Added elastic search support for indexer instead of "bleve"

Ref issue: #6648

@jeffliu27 jeffliu27 changed the title [WIP] Implement [WIP] Implement Elastic Search Code Indexer Jul 23, 2019
guillep2k
guillep2k reviewed Aug 14, 2019
View reviewed changes
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like I've been PR'ing on the same subject without realizing you were already working on it. For that I apologize. I leave you here a couple of highlights about my findings.

modules/indexer/codes/bleve.go
"type": custom.Name,
"char_filters": []string{},
"tokenizer": unicode.Name,
"token_filters": []string{unicodeNormalizeName, camelcase.Name, lowercase.Name, unique.Name},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to reconsider using camelcase and unique. See #7733, #7825 and #7826.

modules/indexer/codes/indexer.go
&IndexerData{
RepoID: repo.ID,
Filepath: update.Filename,
Content: string(fileContents),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to make sure the file contents is valid utf-8. See #7809 and #7814.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 14, 2019
@guillep2k
Copy link
Member

Is this PR still alive? Otherwise I'd like to take #3670.

@jeffliu27
Copy link
Author

Is this PR still alive? Otherwise I'd like to take #3670.

Yes, planning on finishing it. (Haven't gotten a chance to work on it recently)

@Cellebyte
Copy link

@jeffliu27 do you had some time for this feature?.

@Cellebyte
Copy link

@jeffliu27 do you had some time for this feature?.

@jeffliu27 are you still working on this?

@stale
Copy link

stale bot commented Feb 7, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 7, 2020
@Cellebyte
Copy link

Cellebyte commented Feb 7, 2020 •
edited
Loading

@lunny can this here be implemented with the same logic as you are implementing the issue indexer?

@stale stale bot removed the issue/stale label Feb 7, 2020
@lunny
Copy link
Member

lunny commented Feb 11, 2020

@Cellebyte Yes. I will do that and replace this one if my previous issue indexer merged.

@ksa-real
Copy link

@jeffliu27 Any news on your diff? It seems your code has conflicts.

@stale
Copy link

stale bot commented May 27, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label May 27, 2020
@stale
Copy link

stale bot commented Jul 26, 2020

This pull request has been automatically closed because of inactivity. You can re-open it if needed.

@stale stale bot closed this Jul 26, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guillep2k guillep2k guillep2k left review comments

Assignees
No one assigned
Labels
issue/stale lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jeffliu27 @guillep2k @Cellebyte @lunny @ksa-real @GiteaBot