Add Pagination to Releases-page (and de-duplicate pagination templates) #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkcsoft
added
type/enhancement
Current coverage is 2.18% (diff: 0.00%)@@ master #73 diff @@
========================================
Files 31 31
Lines 7508 7510 +2
Methods 0 0
Messages 0 0
Branches 0 0
========================================
Hits 164 164
- Misses 7327 7329 +2
Partials 17 17
|
tboerger
reviewed
Nov 4, 2016
| @@ -75,6 +75,7 @@ | |||
| </li> | |||
| {{end}} | |||
| </ul> | |||
| {{template "admin/base/page" .}} | |||
There was a problem hiding this comment.
An admin pager in the frontend? ;)
There was a problem hiding this comment.
We can copy admin/base/page to base/page and fix here since user's pager maybe not the same style with admin pager.
There was a problem hiding this comment.
A agree that it is in the wrong place, but it does the right thing 😄
IMO it should be moved to base/pagination.tmpl and everything should use that. (Pagination should not require customization...)
bkcsoft
changed the title
to reduce code-duplicity
bkcsoft
force-pushed
the
gt/2164-release-pagination
branch
from
129f646
to
562f9b6
Compare
bkcsoft
changed the title
Current coverage is 2.24% (diff: 0.00%)@@ master #73 diff @@
========================================
Files 32 32
Lines 7521 7523 +2
Methods 0 0
Messages 0 0
Branches 0 0
========================================
Hits 169 169
- Misses 7335 7337 +2
Partials 17 17
|
|
LGTM |
bkcsoft
changed the title
|
LGTM (but didn't test visually, just trusting @bkcsoft ) |
tboerger
added
the
lgtm/done
lunny
pushed a commit
to lunny/gitea
that referenced
this pull request
Feb 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #68