Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Website binding MaxSize to 255 #722

Merged
merged 1 commit into from
Jan 25, 2017
Merged

Conversation

Bwko
Copy link
Member

@Bwko Bwko commented Jan 22, 2017

Fixes #713

@appleboy
Copy link
Member

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 23, 2017
@lunny lunny added this to the 1.1.0 milestone Jan 23, 2017
@lunny
Copy link
Member

lunny commented Jan 23, 2017

if 100 is enough for a URL?

@lunny lunny added the type/bug label Jan 23, 2017
@appleboy
Copy link
Member

@Bwko
Copy link
Member Author

Bwko commented Jan 23, 2017

100 seems to be the Gitea default, but we could change them to 255.

@plessbd
Copy link

plessbd commented Jan 23, 2017

My current use case is less than 100, so as long as I can use that I am fine. However, I would suggest setting the limit to urls to 2047 since that seems to be the maximum that search engines will crawl according to the SO article posted earlier

@tboerger
Copy link
Member

Make sure that the db column is set to 255 and do the same here

@Bwko Bwko changed the title Updated AdminEditUserForm Website binding Updated Website binding MaxSize to 255 Jan 24, 2017
@Bwko Bwko changed the title Updated Website binding MaxSize to 255 Update Website binding MaxSize to 255 Jan 24, 2017
@Bwko
Copy link
Member Author

Bwko commented Jan 24, 2017

I've updated all website binding MaxSize to 255

@tboerger
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 24, 2017
@lunny
Copy link
Member

lunny commented Jan 25, 2017

Not changed the XORM struct?

@Bwko
Copy link
Member Author

Bwko commented Jan 25, 2017

Default is 255? Since I can't find "VARCHAR(255)" anywhere in the code

@lunny
Copy link
Member

lunny commented Jan 25, 2017

Yes, default is 255.

@lunny lunny merged commit 634ac9c into go-gitea:master Jan 25, 2017
@Bwko Bwko deleted the user_edit branch January 25, 2017 08:19
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to edit user as admin
5 participants