Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make modules/structs as a separate go mod #7127

Merged
merged 2 commits into from
Jun 10, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 5, 2019

@lunny
Copy link
Member Author

lunny commented Jun 5, 2019

This should be ci skip, gitea build will depend code.gitea.io/gitea/modules/structs

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 5, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 5, 2019
@zeripath zeripath changed the title Make modules/structs as a spereate go mod Make modules/structs as a separate go mod Jun 5, 2019
@jonasfranz jonasfranz added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Jun 10, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 10, 2019
@jonasfranz
Copy link
Member

@lunny please merge by ignoring drone

@lunny lunny merged commit 835b53f into go-gitea:master Jun 10, 2019
@lunny lunny deleted the lunny/structs_as_mod branch June 10, 2019 15:20
lunny added a commit that referenced this pull request Jun 10, 2019
techknowlogick pushed a commit that referenced this pull request Jun 10, 2019
@zeripath zeripath added this to the 1.9.0 milestone Jul 6, 2019
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
zeripath added a commit to zeripath/gitea that referenced this pull request Nov 23, 2019
Although go-gitea#7300 properly shadows the password from the virtual session
provider, the template displaying the provider config still presumed
that the config was JSON.

This PR updates the template and properly hides the Virtual Session
provider.

Fixes go-gitea#7127
techknowlogick pushed a commit that referenced this pull request Nov 28, 2019
* Properly fix #7127

Although #7300 properly shadows the password from the virtual session
provider, the template displaying the provider config still presumed
that the config was JSON.

This PR updates the template and properly hides the Virtual Session
provider.

Fixes #7127

* update per @silverwind's suggestion
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Nov 29, 2019
…itea#9137)

* Properly fix go-gitea#7127

Although go-gitea#7300 properly shadows the password from the virtual session
provider, the template displaying the provider config still presumed
that the config was JSON.

This PR updates the template and properly hides the Virtual Session
provider.

Fixes go-gitea#7127

* update per @silverwind's suggestion
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK depends on Gitea
5 participants