Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown: enable some more extensions #6362

Merged
merged 3 commits into from
Mar 21, 2019
Merged

Markdown: enable some more extensions #6362

merged 3 commits into from
Mar 21, 2019

Conversation

rkoe
Copy link
Contributor

@rkoe rkoe commented Mar 18, 2019

Improve Markdown-rendering by enabling some extensions:

  • enable definitions lists
  • enable footnotes
  • enable header-ids and automatically generate header-ids (for linking to README-sections or creating table-of-contents for larger READMEs)

Should close issue #1480 without adding any configuration option.

Signed-off-by: Roland Koebler [email protected]

Improve Markdown-rendering by enabling some extensions:

- enable definitions lists
- enable footnotes
- enable header-ids and automatically generate header-ids (for linking to README-sections or creating table-of-contents for larger READMEs)
@techknowlogick techknowlogick added the type/enhancement An improvement of existing functionality label Mar 18, 2019
@techknowlogick techknowlogick added this to the 1.9.0 milestone Mar 18, 2019
@techknowlogick
Copy link
Member

Thanks for PR @rkoe 😃 Could you update the failed tests as well. You can see the ones that failed here: https://drone.gitea.io/go-gitea/gitea/6984/11

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 18, 2019
@rkoe rkoe force-pushed the master branch 3 times, most recently from ceec890 to a5b1a71 Compare March 19, 2019 10:55
Update and add tests for additionally enabled Markdown-extensions.
@codecov-io
Copy link

codecov-io commented Mar 19, 2019

Codecov Report

Merging #6362 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6362   +/-   ##
=======================================
  Coverage   38.86%   38.86%           
=======================================
  Files         365      365           
  Lines       51389    51389           
=======================================
  Hits        19970    19970           
- Misses      28546    28551    +5     
+ Partials     2873     2868    -5
Impacted Files Coverage Δ
modules/markup/markdown/markdown.go 78.7% <ø> (+5.55%) ⬆️
models/unit.go 0% <0%> (-14.29%) ⬇️
routers/repo/view.go 41.08% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f2e1bd...ac05cf4. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 21, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 21, 2019
@lafriks lafriks merged commit 57ecf09 into go-gitea:master Mar 21, 2019
@apricote
Copy link
Contributor

Would it be possible to backport this to release/v1.8?

@lafriks
Copy link
Member

lafriks commented Mar 21, 2019

@apricote sorry but only bugs are backported now

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants