Use url.PathEscape to escape the branchname #6304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6304 +/- ##
==========================================
- Coverage 38.82% 38.81% -0.01%
==========================================
Files 359 359
Lines 51100 51100
==========================================
- Hits 19838 19836 -2
- Misses 28391 28393 +2
Partials 2871 2871
Continue to review full report at Codecov.
|
jolheiser
approved these changes
Mar 11, 2019
…ner and reponame are provided by the client
lafriks
approved these changes
Mar 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently not possible to push a branch containing a
%in it's name as it causes the internal protected branch checking api to return an error.This code protects the branchname with
url.PathEscape