Override xorm type mapping for U2F counter

[mporrato]

Fix U2F authentication failure with token counter value >= 2^31 when using PostgreSQL.
Closes #6168

[codecov-io]

Codecov Report

Merging #6232 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #6232      +/-   ##
==========================================
- Coverage   38.86%   38.83%   -0.03%     
==========================================
  Files         354      355       +1     
  Lines       50223    50239      +16     
==========================================
- Hits        19517    19511       -6     
- Misses      27879    27901      +22     
  Partials     2827     2827

Impacted Files	Coverage Δ
models/migrations/migrations.go	1.52% <ø> (ø)	⬆️
models/u2f.go	63.15% <ø> (ø)	⬆️
models/migrations/v81.go	0% <0%> (ø)
models/repo_list.go	66.84% <0%> (-1.06%)	⬇️
routers/repo/view.go	41.08% <0%> (-1%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 141c58f...6c751fa. Read the comment docs.

[jonasfranz]

Maybe you should consider to add a migration.

[lafriks]

Yes, this would need to add migration to update exisiting database

[lunny]

Yesterday, I'm also investigate this bug. My yubikey could work with github but not gitea. I will try this PR to check if it fixed the bug.

[lunny]

But it seems this doesn't fix my issue.

[mporrato]

@lafriks I believe updating the sqlite3 schema is not needed since it has a single integer type which is big enough to hold an uint32. Sorry for my poor xorm knowledge: haven't used it before. :)

@lunny have you checked if your logs look like https://gist.github.com/mporrato/251450f7786075a887ad21a1728a5407 ? If that's the case, can you connect to the gitea db and do a \d u2f_registration ?

[lafriks]

No need to be sorry about, that's why there is review process to learn things :)

[techknowlogick]

I don’t think we need tidb case because for tidb v2 the protocol would be MySQL. Also should sessions be used?

[lafriks]

@techknowlogick no session is needed for single sql command

[hpodhaisky]

Is this problem still open? I am still getting "Could not read your security key." with gitea 1.12.1 with sqlite3 on debian stable (buster). My solo key NFC works with github.

Update (Solved): The server had two names which can be used synonymously -- but not with the u2f. The error "could not read" disappears if the same name is used for registering and using the dongle.