Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds MustChangePassword to user create/edit API #6193

Merged
merged 2 commits into from
Feb 27, 2019
Merged

Adds MustChangePassword to user create/edit API #6193

merged 2 commits into from
Feb 27, 2019

Conversation

jolheiser
Copy link
Member

This adds the MustChangePassword field to user creation/editing via the admin API endpoints.
Defaults to true, same as CLI.

@lafriks lafriks added pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! modifies/api This PR adds API routes or modifies them labels Feb 26, 2019
@lafriks lafriks added this to the 1.8.0 milestone Feb 26, 2019
@codecov-io
Copy link

codecov-io commented Feb 26, 2019 •
edited
Loading

Codecov Report

Merging #6193 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6193      +/-   ##
==========================================
- Coverage   38.87%   38.86%   -0.02%     
==========================================
  Files         354      354              
  Lines       50192    50198       +6     
==========================================
- Hits        19513    19508       -5     
- Misses      27855    27865      +10     
- Partials     2824     2825       +1
Impacted Files Coverage Δ
routers/api/v1/admin/user.go 21.97% <0%> (-0.5%) ⬇️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo_list.go 66.84% <0%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1ffe7e...631b74b. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 26, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 27, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 27, 2019
@jolheiser jolheiser mentioned this pull request Feb 27, 2019
Closed
@lafriks lafriks merged commit 7548037 into go-gitea:master Feb 27, 2019
@jolheiser jolheiser deleted the must_change_password_api branch February 27, 2019 19:38
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adelowo adelowo adelowo approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it!
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jolheiser @codecov-io @lafriks @adelowo @GiteaBot @zeripath