-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Make document body a flexbox #6139
Conversation
552ba10
to
e15f5cd
Compare
Codecov Report
@@ Coverage Diff @@
## master #6139 +/- ##
==========================================
- Coverage 38.88% 38.88% -0.01%
==========================================
Files 354 354
Lines 50184 50184
==========================================
- Hits 19516 19514 -2
- Misses 27842 27844 +2
Partials 2826 2826
Continue to review full report at Codecov.
|
128cd82
to
0d46fff
Compare
Did you check on ie11? |
Not yet, but Firefox, Chrome and Safari all look well. |
IE11 appears to affected by some kind of flexbug, not sure. Somehow What's the plan for IE11? I dropped support in most of my projects, maybe we can too? |
Removing |
I think we still should support IE11 as that is latest IE version |
a1dd2be
to
29e1b94
Compare
IE 11 fixed and rebased. This should be ready to review. |
Fixes: #6118
Also got rid of
@footer-margin
which added 40px padding on bottom of some pages. Did that in the parent instead, so now the graph page also has some needed padding at the bottom.