Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if a repo does not exist, show a 404 not a 500 #5900

Merged
merged 2 commits into from
Jan 30, 2019
Merged

if a repo does not exist, show a 404 not a 500 #5900

merged 2 commits into from
Jan 30, 2019

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Jan 30, 2019

Fixes #5892

zeripath
zeripath approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that really the OPs issue? Great catch!

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 30, 2019
@adelowo
Copy link
Member Author

adelowo commented Jan 30, 2019

I believe so

When I change the ?repo= to be 0 it works and shows the correct repo. All other repos work fine.

But then again maybe we can wait till he replies to #5892 (comment). But I sincerely believe this is the fix.

@codecov-io
Copy link

codecov-io commented Jan 30, 2019 •
edited
Loading

Codecov Report

Merging #5900 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5900      +/-   ##
==========================================
+ Coverage      38%   38.01%   +<.01%     
==========================================
  Files         328      328              
  Lines       48331    48334       +3     
==========================================
+ Hits        18370    18375       +5     
+ Misses      27323    27321       -2     
  Partials     2638     2638
Impacted Files Coverage Δ
routers/user/home.go 41.16% <0%> (-0.35%) ⬇️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a967cf9...094c555. Read the comment docs.

@zeripath
Copy link
Contributor

It's certainly a fix!

@adelowo
Copy link
Member Author

adelowo commented Jan 30, 2019 •
edited
Loading

Can someone with the correct rights restart the build?

The failure seem unrelated as it passed at https://drone.gitea.io/go-gitea/gitea/5598

Failed to restart your build

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 30, 2019
@techknowlogick techknowlogick added this to the 1.8.0 milestone Jan 30, 2019
@techknowlogick techknowlogick merged commit 8b5f6ce into go-gitea:master Jan 30, 2019
@adelowo adelowo deleted the unknown_repo_should_return_404 branch January 30, 2019 16:25
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

Pull request overview page getting 404 (?repo=)
5 participants
@adelowo @codecov-io @zeripath @techknowlogick @GiteaBot