Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API to list tags #5850

Merged
merged 7 commits into from
Feb 7, 2019
Merged

Add API to list tags #5850

merged 7 commits into from
Feb 7, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 25, 2019 •
edited
Loading

blocked by go-gitea/go-sdk#139

blocked by go-gitea/git#143

@lunny lunny added type/enhancement An improvement of existing functionality modifies/api This PR adds API routes or modifies them labels Jan 25, 2019
kolaente
kolaente suggested changes Jan 26, 2019
View reviewed changes
Copy link
Member

@kolaente kolaente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please generate swagger docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 26, 2019
@techknowlogick techknowlogick added this to the 1.8.0 milestone Jan 26, 2019
@lunny
Copy link
Member Author

lunny commented Jan 28, 2019

should fix #5693

@codecov-io
Copy link

codecov-io commented Jan 28, 2019 •
edited
Loading

Codecov Report

Merging #5850 into master will increase coverage by 0.04%.
The diff coverage is 87.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5850      +/-   ##
==========================================
+ Coverage   38.71%   38.76%   +0.04%     
==========================================
  Files         330      332       +2     
  Lines       48884    48938      +54     
==========================================
+ Hits        18924    18969      +45     
- Misses      27215    27222       +7     
- Partials     2745     2747       +2
Impacted Files Coverage Δ
routers/api/v1/convert/convert.go 79.26% <100%> (+1.78%) ⬆️
routers/api/v1/api.go 73.89% <100%> (+0.15%) ⬆️
models/repo_tag.go 62.5% <62.5%> (ø)
routers/api/v1/repo/tag.go 86.66% <86.66%> (ø)
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d213b6...b405f9d. Read the comment docs.

techknowlogick
techknowlogick requested changes Jan 28, 2019
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add API tests

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 7, 2019
@lafriks
Copy link
Member

lafriks commented Feb 7, 2019

@kolaente need your approval

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 7, 2019
@zeripath zeripath merged commit 01bbf5e into go-gitea:master Feb 7, 2019
@lunny lunny mentioned this pull request Feb 7, 2019
Closed
@lunny lunny deleted the lunny/list_tags branch February 8, 2019 14:31
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kolaente kolaente kolaente approved these changes

@sapk sapk sapk approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
8 participants
@lunny @codecov-io @lafriks @techknowlogick @sapk @kolaente @zeripath @GiteaBot