Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow empty titles (Backport of #5785) #5794

Merged
merged 1 commit into from
Jan 21, 2019

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Jan 21, 2019

Backport #5785

* add util method and tests

* make sure the title of an issue cannot be empty

* wiki title cannot be empty

* pull request title cannot be empty

* update to make use of the new util methof
@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 21, 2019
@lafriks lafriks added this to the 1.7.0 milestone Jan 21, 2019
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 21, 2019
@lafriks lafriks merged commit 4577cdd into go-gitea:release/v1.7 Jan 21, 2019
@adelowo adelowo deleted the backport_4720 branch January 21, 2019 15:55
@adelowo adelowo changed the title Disallow empty titles (#5785) Disallow empty titles (Backport of #5785) Jan 31, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants