Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ldap: Adjust log settings when a user is not found. #5771

Merged
merged 2 commits into from
Jan 19, 2019
Merged

ldap: Adjust log settings when a user is not found. #5771

merged 2 commits into from
Jan 19, 2019

Conversation

HarshitOnGitHub
Copy link
Contributor

@HarshitOnGitHub HarshitOnGitHub commented Jan 19, 2019 •
edited
Loading

Fixes: #3849.

@codecov-io
Copy link

codecov-io commented Jan 19, 2019 •
edited
Loading

Codecov Report

Merging #5771 into master will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5771   +/-   ##
=======================================
  Coverage   37.73%   37.73%           
=======================================
  Files         327      327           
  Lines       47818    47818           
=======================================
  Hits        18043    18043           
  Misses      27181    27181           
  Partials     2594     2594
Impacted Files Coverage Δ
modules/auth/ldap/ldap.go 51.62% <33.33%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c212c98...9ce90bf. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 19, 2019
@lafriks lafriks added the type/enhancement An improvement of existing functionality label Jan 19, 2019
@lafriks lafriks added this to the 1.8.0 milestone Jan 19, 2019
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 19, 2019
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 19, 2019
@techknowlogick techknowlogick merged commit 6822a89 into go-gitea:master Jan 19, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

ldap: an error is logged when a user is not an admin
6 participants
@HarshitOnGitHub @codecov-io @lafriks @zeripath @techknowlogick @bkcsoft