Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct value for "MSpan Structures Obtained" #4742 #5706

Merged
merged 2 commits into from
Jan 12, 2019
Merged

fix: use correct value for "MSpan Structures Obtained" #4742 #5706

merged 2 commits into from
Jan 12, 2019

Conversation

apricote
Copy link
Contributor

Fixes #4742

@codecov-io
Copy link

codecov-io commented Jan 12, 2019 •
edited
Loading

Codecov Report

Merging #5706 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5706      +/-   ##
==========================================
+ Coverage   37.76%   37.81%   +0.04%     
==========================================
  Files         323      323              
  Lines       47596    47596              
==========================================
+ Hits        17977    17997      +20     
+ Misses      27030    27011      -19     
+ Partials     2589     2588       -1
Impacted Files Coverage Δ
modules/indexer/repo.go 68.7% <0%> (+5.34%) ⬆️
models/repo_indexer.go 50% <0%> (+5.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e9d1b8...03d00c1. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 12, 2019
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 12, 2019
@lunny lunny added the type/bug label Jan 12, 2019
@lunny lunny modified the milestones: 1.6.4, 1.8.0 Jan 12, 2019
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 12, 2019
@techknowlogick techknowlogick merged commit e5228b8 into go-gitea:master Jan 12, 2019
@techknowlogick
Copy link
Member

@apricote thanks for PR 😄 Would you be able to send a backport to release/v1.7 and release/v1.6?

@apricote
Copy link
Contributor Author

@techknowlogick Will do.

This was referenced Jan 13, 2019
Merged
Merged
lafriks pushed a commit that referenced this pull request Jan 13, 2019
@apricote @lafriks
fix: use correct value for "MSpan Structures Obtained" #4742 (#5706) (#…
937857e 
…5715)

Signed-off-by: Julian Tölle <[email protected]>
lafriks pushed a commit that referenced this pull request Jan 13, 2019
@apricote @lafriks
fix: use correct value for "MSpan Structures Obtained" #4742 (#5706) (#…
8d40032 
…5716)

Signed-off-by: Julian Tölle <[email protected]>
@lafriks lafriks added the backport/done All backports for this PR have been created label Jan 13, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

"MSpan Structures Obtained" in System Status shows HeapSys value
7 participants
@apricote @codecov-io @techknowlogick @lunny @zeripath @lafriks @bkcsoft