Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not display the raw OpenID error in the UI #5705

Merged
merged 4 commits into from
Jan 12, 2019
Merged

Do not display the raw OpenID error in the UI #5705

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9749661
Do not display the raw OpenID error in the UI
zeripath Jan 11, 2019
6b08894
Update auth_openid.go
zeripath Jan 12, 2019
327f45e
Merge branch 'master' into issue-4793-ssrf-in-openid
techknowlogick Jan 12, 2019
4b76b48
Merge branch 'master' into issue-4793-ssrf-in-openid
techknowlogick Jan 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update auth_openid.go 
Place error log within the `err != nil` branch.
  • Loading branch information
@zeripath
zeripath committed Jan 12, 2019
commit 6b08894f01a9e29f1373fc1a194fea5f09ef02ec
2 changes: 1 addition & 1 deletion routers/user/auth_openid.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ func SignInOpenIDPost(ctx *context.Context, form auth.SignInOpenIDForm) {

redirectTo := setting.AppURL + "user/login/openid"
url, err := openid.RedirectURL(id, redirectTo, setting.AppURL)
log.Error(1, "Error in OpenID redirect URL: %s, %v", redirectTo, err.Error())
if err != nil {
log.Error(1, "Error in OpenID redirect URL: %s, %v", redirectTo, err.Error())
ctx.RenderWithErr(fmt.Sprintf("Unable to find OpenID provider in %s", redirectTo), tplSignInOpenID, &form)
return
}
Expand Down