Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete organization endpoint added #5601

Merged
merged 7 commits into from
Dec 27, 2018
Merged

Conversation

shashvat-kedia
Copy link
Contributor

Fix to issue #5499

New API endpoint added:-
DELETE api/v1/orgs/{org}

@techknowlogick techknowlogick added type/enhancement An improvement of existing functionality modifies/api This PR adds API routes or modifies them labels Dec 27, 2018
@techknowlogick techknowlogick added this to the 1.8.0 milestone Dec 27, 2018
@codecov-io
Copy link

codecov-io commented Dec 27, 2018

Codecov Report

Merging #5601 into master will decrease coverage by 0.01%.
The diff coverage is 9.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5601      +/-   ##
==========================================
- Coverage   37.53%   37.52%   -0.02%     
==========================================
  Files         322      322              
  Lines       47286    47307      +21     
==========================================
+ Hits        17749    17750       +1     
- Misses      26986    27006      +20     
  Partials     2551     2551
Impacted Files Coverage Δ
routers/api/v1/org/org.go 42.38% <0%> (-6.48%) ⬇️
routers/api/v1/api.go 73.45% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21357a4...308f9a4. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 27, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 27, 2018
@lafriks lafriks modified the milestones: 1.8.0, 1.7.0 Dec 27, 2018
@lafriks
Copy link
Member

lafriks commented Dec 27, 2018

I moved it to 1.7.0 as it is small change

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 27, 2018
@zeripath
Copy link
Contributor

Hmm... @lafriks Something went horribly wrong during the MSSQL continuous integration test in build https://drone.gitea.io/go-gitea/gitea/4694 and it looks like the Gitea server went down mid-test. This doesn't seem to be due to these changes.

Restarting the CI through a remerge into master might fix this

@jonasfranz jonasfranz merged commit 6e20b50 into go-gitea:master Dec 27, 2018
@shashvat-kedia shashvat-kedia deleted the Fix-5499 branch December 27, 2018 16:30
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants