Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix makefile generate buildstep #5556

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Fix makefile generate buildstep #5556

merged 1 commit into from
Dec 17, 2018

Conversation

jonasfranz
Copy link
Member

Fixes drone

@jonasfranz jonasfranz added type/bug topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile labels Dec 17, 2018
@jonasfranz jonasfranz added this to the 1.7.0 milestone Dec 17, 2018
@codecov-io
Copy link

Codecov Report

Merging #5556 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5556      +/-   ##
==========================================
+ Coverage   37.56%   37.56%   +<.01%     
==========================================
  Files         320      320              
  Lines       47144    47144              
==========================================
+ Hits        17708    17710       +2     
+ Misses      26893    26891       -2     
  Partials     2543     2543
Impacted Files Coverage Δ
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3b7598...427e953. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 17, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 17, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 17, 2018
@jonasfranz jonasfranz merged commit 94c3963 into go-gitea:master Dec 17, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@kolaente kolaente kolaente approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/bug
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jonasfranz @codecov-io @techknowlogick @kolaente @bkcsoft