Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reverse proxy providing email #5554

Merged

Conversation

zeripath
Copy link
Contributor

This PR implements #2347 by allowing the reverse proxy to set the email address on auto-register.

The current implementation does not allow for changing the email address using the reverse proxy - perhaps it should?

Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add to example app.ini the conf value as well

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 16, 2018
@zeripath
Copy link
Contributor Author

I knew there was somewhere else. The other values aren't in the example app.ini - I guess I should add those too

@zeripath zeripath force-pushed the issue-2347-support-reverse-proxy-email branch from a5a3439 to 3636c9b Compare December 17, 2018 19:13
@zeripath
Copy link
Contributor Author

I knew there was somewhere else. The other values aren't in the example app.ini - I guess I should add those too

OK that was weird - so I searched again today and the original values pop up in the app.ini.sample ... I'm not sure what happened there!

@zeripath
Copy link
Contributor Author

@techknowlogick : I've added the appropriate lines to custom/conf/app.ini.sample

Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeripath Look's great!

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 17, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 17, 2018
@techknowlogick techknowlogick added the type/enhancement An improvement of existing functionality label Dec 18, 2018
@techknowlogick techknowlogick added this to the 1.7.0 milestone Dec 18, 2018
@codecov-io
Copy link

Codecov Report

Merging #5554 into master will decrease coverage by <.01%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5554      +/-   ##
==========================================
- Coverage   37.55%   37.54%   -0.01%     
==========================================
  Files         321      321              
  Lines       47172    47181       +9     
==========================================
- Hits        17714    17713       -1     
- Misses      26916    26924       +8     
- Partials     2542     2544       +2
Impacted Files Coverage Δ
routers/admin/admin.go 0% <0%> (ø) ⬆️
modules/auth/auth.go 53.47% <0%> (-1.78%) ⬇️
modules/setting/setting.go 48.55% <100%> (+0.12%) ⬆️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe55ab2...fd960d5. Read the comment docs.

@techknowlogick techknowlogick merged commit 2a660a1 into go-gitea:master Dec 18, 2018
@zeripath zeripath deleted the issue-2347-support-reverse-proxy-email branch December 18, 2018 18:29
@lafriks lafriks added the type/changelog Adds the changelog for a new Gitea version label Dec 19, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@delvh delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants